fix: export FlagSource enum as runtime value #349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export FlagSource enum from all entry points to make it usable as both a type and runtime value in consumer code.
Previously, FlagSource was only exported as a type declaration, which prevented users from comparing against enum values like FlagSource.NONE in their code. Users had to use workarounds with string literals and type assertions.
Changes:
Users can now use:
import { FlagSource } from 'flagsmith';
if (loadingState.source === FlagSource.NONE) { ... }
Why Re-export from Each Entry Point?
Each entry point file (
index.ts,isomorphic.ts,index.react-native.ts,next-middleware.ts) creates a separate JavaScript bundle via Rollup. Users import from different paths depending on their environment:The Problem Without Re-exports
When Rollup bundles each entry point, it only exports what that specific entry file explicitly exports:
Result: SSR users would get an error:
The Solution: Explicit Re-exports
By adding
export { FlagSource } from './flagsmith-core'to each entry point, the bundled files properly expose it:Result: All users can access
FlagSourceregardless of which entry point they use.